Fix for swept box rays that were never really working properly with OBBs. (IntersectRayWithOBB) #590
+10
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IntersectRayWithOBB has a bug where it would somehow ignore angle information inside the matrix.
Why? I don't know. Maybe some developers not wanting to use VectorTransform somehow ? (or overworked)
This is probably present in all Source games (including Source 2) if it hasn't been fixed yet. (?)
This fixes some edge cases where for example a game mod wants to have thicker bullets or other stuff that I'm not aware of (I discovered it by accident by working on the engine).