Accessibility for options page #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested this on local and everything appears to be working as expected.
Will be creating another pull request with the updated plugin screenshots. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #536 this improves the accessibility for the options page by:
The QR library we use does not provide the needed ability to set the title/role, which is why I've used JS to set these.
I'm not sure of the best text to use as a
titlefor the QR code, but I thinkAuthenticator App QR Codeis reasonably descriptive yet short enough.Why?
This makes the page more accessible to screen readers
How?
Testing Instructions
Screenshots or screencast
Changelog Entry
Fixed - Improved accessibility of the options screen.