Disable STRIP operations when appropriate. #5127
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the reasons/motivation for this change?
It was always difficult to debug the logic in yosys when using it as a dynamic library, and it was further discovered that this was because STRIP was always used to remove symbol information in yosys when installing yosys, regardless of how ENABLE_DEBUG was set. I don't know if this is by design or just an unexpected behavior.
Explain how this is achieved.
The STRIP variable is cleared when ENABLE_DEBUG is set to 1, and validity checks are performed everywhere the STRIP variable is used.
If applicable, please suggest to reviewers how they can test the change.
Build with ENABLE_DEBUG=1 and inspect with a debug symbol viewing tool.