Skip to content

Disassembler: Support special (non-standard) encodings (widening FP ops) #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Disassembler: Support special (non-standard) encodings (widening FP ops) #96

wants to merge 2 commits into from

Conversation

a4lg
Copy link
Owner

@a4lg a4lg commented Nov 28, 2022

@a4lg a4lg added bug Something isn't working enhancement New feature or request labels Nov 28, 2022
@a4lg a4lg force-pushed the riscv-dis-support-special-encodings-1 branch 3 times, most recently from 2c13c79 to 3ff6861 Compare December 2, 2022 03:27
@a4lg a4lg force-pushed the riscv-dis-support-special-encodings-1 branch 4 times, most recently from 14525e5 to 0d97040 Compare December 11, 2022 06:32
@a4lg a4lg force-pushed the riscv-dis-support-special-encodings-1 branch 5 times, most recently from 3908ce7 to 0e1a658 Compare December 25, 2022 02:53
@a4lg a4lg force-pushed the riscv-dis-support-special-encodings-1 branch 4 times, most recently from 424d58a to 0543524 Compare December 29, 2022 07:50
@a4lg a4lg force-pushed the riscv-dis-support-special-encodings-1 branch 6 times, most recently from f751871 to 51b4491 Compare January 7, 2023 02:33
@a4lg a4lg force-pushed the riscv-dis-support-special-encodings-1 branch 3 times, most recently from 537778d to bd15d54 Compare January 16, 2023 08:39
@a4lg a4lg force-pushed the riscv-dis-support-special-encodings-1 branch 3 times, most recently from 43c6a34 to bf83caa Compare January 26, 2023 01:32
@a4lg a4lg force-pushed the riscv-dis-support-special-encodings-1 branch 3 times, most recently from 9def8bd to ec8d399 Compare February 8, 2023 05:34
@a4lg a4lg force-pushed the riscv-dis-support-special-encodings-1 branch from ec8d399 to db050ed Compare February 15, 2023 04:34
@a4lg a4lg force-pushed the riscv-dis-support-special-encodings-1 branch from db050ed to d87c151 Compare March 1, 2023 10:46
@a4lg a4lg force-pushed the riscv-dis-support-special-encodings-1 branch from d87c151 to 962b2ce Compare March 16, 2023 03:02
@a4lg a4lg force-pushed the riscv-dis-support-special-encodings-1 branch 2 times, most recently from bba490f to 80097fa Compare August 1, 2023 03:40
@a4lg a4lg force-pushed the riscv-dis-support-special-encodings-1 branch 8 times, most recently from e36b59b to c0180e6 Compare August 8, 2023 04:11
@a4lg a4lg force-pushed the riscv-dis-support-special-encodings-1 branch 3 times, most recently from 046fbe6 to 9e97e7d Compare August 15, 2023 06:37
@a4lg a4lg force-pushed the riscv-dis-support-special-encodings-1 branch from 9e97e7d to dea6005 Compare August 15, 2023 07:27
@a4lg a4lg force-pushed the riscv-dis-support-special-encodings-1 branch 4 times, most recently from 5c0247e to 776f71f Compare September 7, 2023 09:35
@a4lg a4lg force-pushed the riscv-dis-support-special-encodings-1 branch 2 times, most recently from 7b801ac to 0f8da16 Compare October 19, 2023 03:17
a4lg added 2 commits October 19, 2023 06:58
@a4lg
RISC-V: Reorganize invalid rounding mode test
2cc57a0 
This commit reorganizes and adds testcases to
invalid rounding mode operand test.

gas/ChangeLog:

	* testsuite/gas/riscv/rounding-fail.s: Enhance test cases.
	* testsuite/gas/riscv/rounding-fail.l: Likewise.
@a4lg
RISC-V: Rounding mode on widening instructions
64280c1 
This commit adds support for rounding modes on widening instructions to
the assembler/disassembler.

On the disassembler, non-default rounding mode is displayed when
"no-aliases" option is given or the rounding mode itself is invalid.

On the assembler, specifying such rounding modes is prohibited unless
we have supported in the past.

gas/ChangeLog:

	* config/tc-riscv.c (validate_riscv_insn): Add rounding mode
	support to widening instructions.
	(riscv_ip): Likewise.
	* testsuite/gas/riscv/rounding-dis-widening.d: New disasm test.
	* testsuite/gas/riscv/rounding-dis-widening.s: Likewise.
	* testsuite/gas/riscv/rounding-dis-widening-na.d: Likewise.
	* testsuite/gas/riscv/rounding-fail.d: Add testcases for widening
	instructions.
	* testsuite/gas/riscv/rounding-fail.l: Likewise.
	* testsuite/gas/riscv/rounding-fail.s: Likewise.
	* testsuite/gas/riscv/rounding-fcvt.q.l.d: New test.
	* testsuite/gas/riscv/rounding-fcvt.q.l.l: Likewise.
	* testsuite/gas/riscv/rounding-fcvt.q.l.s: Likewise.
	* testsuite/gas/riscv/rounding-fcvt.q.l-na.d: Likewise.

opcodes/ChangeLog:

	* riscv-dis.c (print_insn_args): Add rounding mode support to
	widening instructions.
	* riscv-opc.c (riscv_opcodes): Use new operand types.

Idea-by: Tsukasa OI <[email protected]>
Idea-by: S Pawan Kumar <[email protected]>
@a4lg a4lg force-pushed the riscv-dis-support-special-encodings-1 branch from 0f8da16 to 64280c1 Compare October 19, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@a4lg