Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump node12 to node16 in actions.yml #434

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

quinnjn
Copy link

@quinnjn quinnjn commented Sep 14, 2022

What this PR does / Why we need it

Bumps node12 to node16. Also requiring at least 16 for install.

Which issue(s) this PR fixes

Keeping node up to date. Node 12 is EOL.

@kaelig
Copy link

kaelig commented Oct 13, 2022

Thank you!

There's still 8 months or so until this action stops working, but it'd be great to see this warning disappear when it runs!

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions-ecosystem/action-add-labels

@quinnjn
Copy link
Author

quinnjn commented Oct 31, 2022

@kaelig is there any other work you'd like to see on this PR or is it ready for a merge?

@kaelig
Copy link

kaelig commented Oct 31, 2022

Looks good to me!

@germa89
Copy link

germa89 commented Nov 22, 2022

Any progress on this?

@gaber85
Copy link

gaber85 commented Feb 9, 2023

Re: any progress on this @quinnjn ?

@quinnjn
Copy link
Author

quinnjn commented Feb 9, 2023

@gaber85 I'm not a maintainer. It's ready to merge when a maintainer chooses too.

@marcofranssen
Copy link

Maybe mention this #459 in the description which issue this resolves.

Resolves #459 

Copy link

@marcofranssen marcofranssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mvolpato
Copy link

Hi @micnncim, any chance to get this merged? If you need help with this kind of work, maybe you can consider adding more people to the organization?

@mccarron
Copy link

Another bump for @micnncim hopefully we can get this merged in?

@aximov aximov added the release/minor Indicates minor update to action-release-label label May 4, 2023
@aximov aximov self-requested a review May 4, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/minor Indicates minor update to action-release-label size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants