-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
depr: deprecate utils.archives
in favor of Dataset.extract()
#1028
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1028 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 80 81 +1
Lines 3602 3609 +7
Branches 646 646
=========================================
+ Hits 3602 3609 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bef6670
to
0a591a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for cleaning up the repo structure. I think there is one PR to split up and some minor changes.
utils.archives
is deprecated. please useDataset.extract()
instead.utils.archives
will be removed in pymovements v0.26.0Description
Deprecate
utils.archives
in favor ofDataset.extract()
The following warning is printed:
partly resolves #999
blocked by #1029
Implemented changes
utils/archives.py
todataset/_utils/_archives.py
and adjusted to new locationdataset._utils.archives
indataset.dataset_download
utils/archives.py
tests/unit/utils/archives_test.py
totests/unit/dataset/_utils/_archives_test.py