-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
depr: Deprecate utils.parsing
in favor of gaze.from_asc()
#976
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #976 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 78 79 +1
Lines 3557 3567 +10
Branches 622 622
=========================================
+ Hits 3557 3567 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
finally |
let's merge this after releasing v0.20.0 |
this is now ready for being merged |
Why was #989 merged before this? |
whoops -- #954 was the pain point 🙈 |
#954 could wait |
I try to resolve the conflicts in this PR |
see #993 |
okay -- if you decide to revert and remerge, lmk and I'll fix #989 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple of feedback questions:
- comment below
- why
gaze/_utils
instead ofgaze/utils
?
I wanted to make sure that users understand that this is a private utils module that is not intended for the end-user. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utils.parsing
is deprecated. please usegaze.from_asc()
instead.utils.parsing
will be removed in pymovements v0.26.0Description
Deprecate
utils.parsing
in favor ofgaze.from_asc()
The following warning is printed:
Fixes #973
Should be merged before #945
Implemented changes
deprecated
as a dependency for@deprecated
decoratorutils/parsing.py
togaze/_utils/parsing.py
and adjusted to new locationgaze._utils.parsing
ingaze.io
utils/parsing.py
tests/unit/utils/parsing_test.py
totests/unit/gaze/_utils/parsing_test.py