Unable to create lifecycle rules to cleanup old versions #2611
Conversation
…-rule Feat/oss/noncurrent version rule
ghost
added
the
akash-jain-10
changed the title
|
this PR addresses the issues mentioned in #2155 |
…-rule go mod vendor
| @@ -176,6 +176,20 @@ func resourceAlicloudOssBucket() *schema.Resource { | |||
| }, | |||
| }, | |||
| }, | |||
| "noncurrent_version_expiration": { | |||
| Type: schema.TypeList, | |||
There was a problem hiding this comment.
这个是否需要和之前 expiration 类型保持一致？
There was a problem hiding this comment.
I have this changed to schema.TypeSet. Modified the code as per the same.
…-rule Feat/oss/noncurrent version rule
| @@ -204,6 +219,31 @@ func resourceAlicloudOssBucket() *schema.Resource { | |||
| }, | |||
| }, | |||
| }, | |||
| "noncurrent_version_transition": { | |||
There was a problem hiding this comment.
这个接口实现有问题。
一个rule 可以设置多个 noncurrent_version_transition 条件。
There was a problem hiding this comment.
Hello @huiguangjun , it seems like the go sdk currently does not support the above said configuration. I have made changes as per the go sdk. Here is the goDoc for Lifecycle Rules struct - https://godoc.org/github.com/aliyun/aliyun-oss-go-sdk/oss#LifecycleRule
The LifecycleRule struct currently takes in 1 object for NonVersionTransition .
Also, it would be great if you continue conversation in english :) ! I have to translate the above comment :P
There was a problem hiding this comment.
@huiguangjun any updates on this ? Let me know your thoughts.
|
Akash Jain seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
@huiguangjun any updates on this? |
|
@huiguangjun @zql-tqy are we good to merge these updates ? |
|
@huiguangjun @zql-tqy Please approve this. We are waiting for this feature. Thank you. |
|
@huiguangjun @zql-tqy. Please approve and merge these updates . We need this feature . |
|
Any update on this ?? |
|
merge to this pr |
Unable to create lifecycle rules to cleanup old versions