Unable to create lifecycle rules to cleanup old versions #2611
+3,638
−8,900
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -176,6 +176,20 @@ func resourceAlicloudOssBucket() *schema.Resource { | |
| }, | ||
| }, | ||
| }, | ||
| "noncurrent_version_expiration": { | ||
| Type: schema.TypeList, | ||
| MaxItems: 1, | ||
| Optional: true, | ||
| Elem: &schema.Resource{ | ||
| Schema: map[string]*schema.Schema{ | ||
| "days": { | ||
| Type: schema.TypeInt, | ||
| Optional: true, | ||
| ValidateFunc: validation.IntAtLeast(1), | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| "transitions": { | ||
| Type: schema.TypeSet, | ||
| Optional: true, | ||
|
|
@@ -204,6 +218,30 @@ func resourceAlicloudOssBucket() *schema.Resource { | |
| }, | ||
| }, | ||
| }, | ||
| "noncurrent_version_transition": { | ||
|
There was a problem hiding this comment. 这个接口实现有问题。 There was a problem hiding this comment. Hello @huiguangjun , it seems like the go sdk currently does not support the above said configuration. I have made changes as per the go sdk. Here is the goDoc for Lifecycle Rules struct - https://godoc.org/github.com/aliyun/aliyun-oss-go-sdk/oss#LifecycleRule The Also, it would be great if you continue conversation in english :) ! I have to translate the above comment :P There was a problem hiding this comment. @huiguangjun any updates on this ? Let me know your thoughts. |
||
| Type: schema.TypeList, | ||
| MaxItems: 1, | ||
| Optional: true, | ||
| Elem: &schema.Resource{ | ||
| Schema: map[string]*schema.Schema{ | ||
| "days": { | ||
| Type: schema.TypeInt, | ||
| Optional: true, | ||
| ValidateFunc: validation.IntAtLeast(1), | ||
| }, | ||
| "storage_class": { | ||
| Type: schema.TypeString, | ||
| Default: oss.StorageStandard, | ||
| Optional: true, | ||
| ValidateFunc: validation.StringInSlice([]string{ | ||
| string(oss.StorageStandard), | ||
| string(oss.StorageIA), | ||
| string(oss.StorageArchive), | ||
| }, false), | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| MaxItems: 1000, | ||
|
|
@@ -932,6 +970,18 @@ func resourceAlicloudOssBucketLifecycleRuleUpdate(client *connectivity.AliyunCli | |
| rule.Expiration = &i | ||
| } | ||
|
|
||
| //NoncurrentVersionExpiration | ||
| nc_expiration := d.Get(fmt.Sprintf("lifecycle_rule.%d.noncurrent_version_expiration", i)).(*schema.Set).List() | ||
| if len(nc_expiration) > 0 && nc_expiration[0] != nil { | ||
| e := nc_expiration[0].(map[string]interface{}) | ||
| i := oss.LifecycleVersionExpiration{} | ||
|
|
||
| if val, ok := e["days"].(int); ok && val > 0 { | ||
| i.NoncurrentDays = val | ||
| rule.NonVersionExpiration = &i | ||
| } | ||
| } | ||
|
|
||
| // Transitions | ||
| transitions := d.Get(fmt.Sprintf("lifecycle_rule.%d.transitions", i)).(*schema.Set).List() | ||
| if len(transitions) > 0 { | ||
|
|
@@ -960,6 +1010,20 @@ func resourceAlicloudOssBucketLifecycleRuleUpdate(client *connectivity.AliyunCli | |
| } | ||
| } | ||
|
|
||
| // NoncurrentVersionTransition | ||
| nc_transition := d.Get(fmt.Sprintf("lifecycle_rule.%d.noncurrent_version_transition", i)).(*schema.Set).List() | ||
| if len(nc_transition) > 0 && nc_expiration[0] != nil { | ||
| e := nc_transition[0].(map[string]interface{}) | ||
| i := oss.LifecycleVersionTransition{} | ||
| valDays := e["days"].(int) | ||
| valStorageClass := e["storage_class"].(string) | ||
|
|
||
| i.NoncurrentDays = valDays | ||
| i.StorageClass = oss.StorageClassType(valStorageClass) | ||
|
|
||
| rule.NonVersionTransition = &i | ||
| } | ||
|
|
||
| rules = append(rules, rule) | ||
| } | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个是否需要和之前 expiration 类型保持一致？
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have this changed to
schema.TypeSet. Modified the code as per the same.