-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable django flags support #15660
Conversation
requirements/requirements.txt
Outdated
@@ -23,7 +23,6 @@ asgiref==3.7.2 | |||
# channels-redis | |||
# daphne | |||
# django | |||
# django-ansible-base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are still dependencies of DAB. They were added somewhat recently.
You probably generated this output incorrectly by using an outdated container image.
I also don't understand why we would add a dependency before we make any use of this dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlanCoding I made sure to pull the latest changes and rebuild the container image. But after running ./updater run
I still end up with the django-ansible-base
comments removed.
requirements/requirements.txt
Outdated
@@ -422,7 +423,6 @@ requests==2.31.0 | |||
# -r /awx_devel/requirements/requirements.in | |||
# adal | |||
# azure-core | |||
# django-ansible-base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to bikeshed on this too much, but requests is still a requirement of DAB resource_registry, which is an AWX requirement.
So yes, it is unexpected that this got removed. But I can't say why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll see if I can find the reason for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlanCoding #15677 has resolved it 👍
SUMMARY
Enable support for django flags.
Verification steps:
docker exec -it tools_awx_1 /bin/bash
python manage.py enable_flag TEST_FLAG
ping
view):True
is printed when accessing the route for the viewpython manage.py disable_flag TEST_FLAG
False
is printedISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION