Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing dependencies due to extras - vs _ #15677

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

AlanCoding
Copy link
Member

SUMMARY

Other PRs ran the requirement generator and dropped dependencies of DAB.

With this change, I run:

docker exec --user=0 -it tools_awx_1 /bin/bash

then

cd requirements/
./updater.sh run

With this, I get no change in the requirements.txt file, unlike other active PRs like #15660 which incorrectly mark requests as not a requirement of DAB. It is, given the extras we select.

I don't know who introduced this problem, but this fixes it for us.

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • API

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Dec 2, 2024
Copy link

sonarqubecloud bot commented Dec 2, 2024

@AlanCoding
Copy link
Member Author

Documenting alternative approach, which seems to be removing setuptools pulp/pulpcore#5658

@AlanCoding AlanCoding marked this pull request as ready for review December 2, 2024 16:50
@AlanCoding AlanCoding merged commit c64b5eb into ansible:devel Dec 2, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants