-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: check all commands are submitted #3501
Conversation
…s module command output.
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3501 +/- ##
=======================================
Coverage 82.33% 82.33%
=======================================
Files 57 57
Lines 10007 10007
=======================================
Hits 8239 8239
Misses 1768 1768 |
@pyansys-ci-bot LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Run all the commands with fake arguments until right the point before submitting the command to the MAPDL instance.
I thought this PR would be for nothing, but I did actually catch several non-matching signatures and a totally mess up command. So... Pretty happy.
Notes
There are several (16) ignored commands because they are overwritten in the subclasses. The output is here:
Issue linked
NA
Checklist
draft
if it is not ready to be reviewed yet.feat: adding new MAPDL command
)