[plugin][pulsar] Handle the SendCallback method sign changed. #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix CI and we need to add the new versions to the test scenarios to verify. Also, you need to make CI passed. |
wu-sheng
reviewed
Aug 20, 2024
CHANGES.md
Outdated
| @@ -6,6 +6,7 @@ Release Notes. | |||
| ------------------ | |||
|
|
|||
| * Upgrade nats plugin to support 2.16.5 | |||
| * [pulsar] Handle the SendCallback class method signature change. | |||
There was a problem hiding this comment.
Suggested change
| * [pulsar] Handle the SendCallback class method signature change. | |
| * Support newer Pulsar versions to adopt SendCallback class method signature change. |
I can't see which versions will include this. The PR you refer to doesn't have the version information.
There was a problem hiding this comment.
The code implementation PR: apache/pulsar#23196.
It will available in the next release.
There was a problem hiding this comment.
We can't accept this PR until it is released and verified through CI tests.
We have to hold this until then.
|
Could you fix the CI first? Then we need to wait for Pulsar's next release. |
|
No update for a month. Close for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In apache/pulsar#22940, Pulsar will change the
org.apache.pulsar.client.impl.SendCallback#sendCompletemethod sign fromto
This PR is to address it.
CHANGESlog.