Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin][pulsar] Handle the SendCallback method sign changed. #715

Closed
wants to merge 5 commits into from
Closed

[plugin][pulsar] Handle the SendCallback method sign changed. #715

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b09f512
Address PIP363
dao-jun Aug 19, 2024
a358cee
Address PIP363
dao-jun Aug 19, 2024
5c3da17
fix ci
dao-jun Aug 21, 2024
63b5e05
update CHANGES.md
dao-jun Aug 21, 2024
59d916e
fix CI
dao-jun Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ Release Notes.
------------------

* Upgrade nats plugin to support 2.16.5
* [pulsar] Handle the SendCallback class method signature change.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [pulsar] Handle the SendCallback class method signature change.
* Support newer Pulsar versions to adopt SendCallback class method signature change.

I can't see which versions will include this. The PR you refer to doesn't have the version information.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code implementation PR: apache/pulsar#23196.
It will available in the next release.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't accept this PR until it is released and verified through CI tests.

We have to hold this until then.



All issues and pull requests are [here](https://github.com/apache/skywalking/milestone/222?closed=1)
Expand Down
6 changes: 3 additions & 3 deletions ...src/main/java/org/apache/skywalking/apm/plugin/pulsar/common/SendCallbackInterceptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,9 @@ public Object afterMethod(EnhancedInstance objInst, Method method, Object[] allA
Object ret) throws Throwable {
SendCallbackEnhanceRequiredInfo requiredInfo = (SendCallbackEnhanceRequiredInfo) objInst.getSkyWalkingDynamicField();
if (null != requiredInfo.getContextSnapshot()) {
Exception exceptions = (Exception) allArguments[0];
if (exceptions != null) {
ContextManager.activeSpan().log(exceptions);
Throwable t = (Throwable) allArguments[0];
if (t != null) {
ContextManager.activeSpan().log(t);
}
ContextManager.stopSpan();
}
Expand Down
Loading