Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise the ITF format #2733

Merged
merged 3 commits into from
Sep 14, 2023
Merged

Revise the ITF format #2733

merged 3 commits into from
Sep 14, 2023

Conversation

konnov
Copy link
Collaborator

@konnov konnov commented Sep 14, 2023

Closes #2732. In this PR, we further simplify the ITF format by always representing integers as { "#bigint": "num" }, instead of having two cases, namely, num for small integers and { "#bigint": "num" } for big integers. This should simplify the usage of ITF in tests.

Copy link
Collaborator

@Kukovec Kukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2023

Codecov Report

Merging #2733 (59fe194) into main (403eb14) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 59fe194 differs from pull request most recent head 848d3f4. Consider uploading reports for the commit 848d3f4 to get more accurate results

@@            Coverage Diff             @@
##             main    #2733      +/-   ##
==========================================
+ Coverage   78.52%   78.53%   +0.01%     
==========================================
  Files         463      463              
  Lines       15904    15900       -4     
  Branches     2563     2539      -24     
==========================================
- Hits        12488    12487       -1     
+ Misses       3416     3413       -3     
Files Changed Coverage Δ
...in/scala/at/forsyte/apalache/io/itf/ItfToTla.scala 98.05% <100.00%> (ø)
...syte/apalache/io/lir/ItfCounterexampleWriter.scala 96.00% <100.00%> (-0.30%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@konnov konnov enabled auto-merge September 14, 2023 09:33
@konnov konnov merged commit 5c0e659 into main Sep 14, 2023
10 checks passed
@shonfeder shonfeder deleted the igor/itf2732 branch October 23, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revise the ITF format
3 participants