Feat(eos_cli_config_gen): Add min-links in port-channel-interfaces #4790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vibhu-gslab
requested review from
MaheshGSLAB,
Shivani-gslab and
laxmikantchintakindi
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4790
# Activate the virtual environment
source test-avd-pr-4790/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@min_links#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,min_links --force
# Optional: Install AVD examples
cd test-avd-pr-4790
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
role: eos_cli_config_gen
MaheshGSLAB
reviewed
Dec 6, 2024
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/port_channel_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
Vibhu-gslab
force-pushed
the
min_links
branch
from
e91e72d to
19d08db
Compare
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/port_channel_interfaces.schema.yml
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/port-channel-interfaces.j2
Outdated
Show resolved
Hide resolved
Vibhu-gslab
force-pushed
the
min_links
branch
from
19d08db to
6075bac
Compare
MaheshGSLAB
approved these changes
Dec 10, 2024
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/port_channel_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
laxmikantchintakindi
approved these changes
Dec 10, 2024
gmuloc
requested changes
Dec 11, 2024
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/port_channel_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
Vibhu-gslab
force-pushed
the
min_links
branch
from
7ff8812 to
417101b
Compare
…ort_channel_interfaces.schema.yml Co-authored-by: laxmikantchintakindi <[email protected]>
for more information, see https://pre-commit.ci
Vibhu-gslab
force-pushed
the
min_links
branch
from
417101b to
f6daf05
Compare
gmuloc
approved these changes
Dec 12, 2024
emilarista
pushed a commit
to emilarista/ansible-avd
that referenced
this pull request
Dec 17, 2024
…ristanetworks#4790) Co-authored-by: laxmikantchintakindi <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Guillaume Mulocher <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Adding min-links in port-channel-interfaces
Related Issue(s)
Fixes part of #4780
Component(s) name
arista.avd.eos_cli_config_genProposed changes
Adding min_links under port-channel-interfaces
Covering below CLI config:
Checklist
Repository Checklist