Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add min-links in port-channel-interfaces #4790

Merged
merged 7 commits into from
Dec 12, 2024
Merged

Feat(eos_cli_config_gen): Add min-links in port-channel-interfaces #4790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0944381
Feat(eos_cli_config_gen): Add min-links in port-channel-interfaces
Vibhu-gslab Dec 5, 2024
77e2c87
fixing Ci
Vibhu-gslab Dec 5, 2024
8a7c391
addressing comments
Vibhu-gslab Dec 10, 2024
f6ef37f
Update python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/p…
Vibhu-gslab Dec 10, 2024
e56478f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 10, 2024
f6daf05
increasing the range
Vibhu-gslab Dec 12, 2024
394987c
Merge branch 'devel' into min_links
gmuloc Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...llections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/host1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5256,6 +5256,7 @@ interface Port-Channel104
switchport trunk allowed vlan 112
switchport mode trunk
switchport
port-channel min-links 3
port-channel lacp fallback individual
port-channel lacp fallback timeout 300
!
Expand Down
1 change: 1 addition & 0 deletions ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/host1.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1926,6 +1926,7 @@ interface Port-Channel104
switchport trunk allowed vlan 112
switchport mode trunk
switchport
port-channel min-links 3
port-channel lacp fallback individual
port-channel lacp fallback timeout 300
!
Expand Down
1 change: 1 addition & 0 deletions ...sta/avd/molecule/eos_cli_config_gen/inventory/host_vars/host1/port-channel-interfaces.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,6 +591,7 @@ port_channel_interfaces:
allowed_vlan: 112
lacp_fallback_timeout: 300
lacp_fallback_mode: individual
min_links: 3

- name: Port-Channel105
switchport:
Expand Down
5 changes: 5 additions & 0 deletions ...ions/arista/avd/roles/eos_cli_config_gen/docs/tables/port-channel-interfaces.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/port-channel-interfaces.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,6 +435,9 @@ interface {{ port_channel_interface.name }}
{% if port_channel_interface.mac_access_group_out is arista.avd.defined %}
mac access-group {{ port_channel_interface.mac_access_group_out }} out
{% endif %}
{% if port_channel_interface.min_links is arista.avd.defined %}
port-channel min-links {{ port_channel_interface.min_links }}
{% endif %}
{% if port_channel_interface.lacp_fallback_mode is arista.avd.defined %}
port-channel lacp fallback {{ port_channel_interface.lacp_fallback_mode }}
{% endif %}
Expand Down
12 changes: 12 additions & 0 deletions python-avd/pyavd/_eos_cli_config_gen/schema/__init__.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions python-avd/pyavd/_eos_cli_config_gen/schema/eos_cli_config_gen.schema.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions ...-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/port_channel_interfaces.schema.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,15 @@ keys:
- str
min: 0
max: 300
min_links:
laxmikantchintakindi marked this conversation as resolved.
Show resolved Hide resolved
type: int
convert_types:
- str
min: 0
max: 120
description: |-
Minimum number of ports required up before bringing up a port-channel.
Maximum in `min_links` is hardware dependent.
lacp_fallback_mode:
type: str
valid_values:
Expand Down
Loading