Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/KBDEV-1249 Unable to Add New Variant Without Positional Information #89

Conversation

bnguyen-bcgsc
Copy link
Contributor

  • Add check if variant has positional information before transforming refSeq and refAA for protein position
  • Undo ternary operator for api response for variant creation/update to get result data for snackbar and redirecting to variant view

- Add check if variant has positional information before transforming refSeq and refAA for protein position
- Undo ternary operator for api response for variant creation/update to get result data for snackbar and redirecting to variant view
@bnguyen-bcgsc bnguyen-bcgsc added the bug Something isn't working label Sep 11, 2024
@bnguyen-bcgsc bnguyen-bcgsc self-assigned this Sep 11, 2024

This comment has been minimized.

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 56.76%. Comparing base (57a594d) to head (980bd7b).

Files with missing lines Patch % Lines
src/components/VariantForm/index.tsx 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #89      +/-   ##
===========================================
- Coverage    56.77%   56.76%   -0.02%     
===========================================
  Files          102      102              
  Lines         3873     3874       +1     
  Branches      1311     1310       -1     
===========================================
  Hits          2199     2199              
- Misses        1662     1663       +1     
  Partials        12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This comment has been minimized.

@bnguyen-bcgsc bnguyen-bcgsc merged commit 8179a92 into develop Sep 12, 2024
3 checks passed
Copy link

Unit Test Results

    1 files  ±0    39 suites  ±0   1m 38s ⏱️ ±0s
160 tests ±0  159 ✔️ ±0  1 💤 ±0  0 ❌ ±0 
156 runs  ±0  155 ✔️ ±0  1 💤 ±0  0 ❌ ±0 

Results for commit 8179a92. ± Comparison against base commit 57a594d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants