Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/KBDEV-1249 Unable to Add New Variant Without Positional Information #89

Merged
merged 3 commits into from
Sep 12, 2024
Merged

bugfix/KBDEV-1249 Unable to Add New Variant Without Positional Information #89

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5eccf6b
- KBDEV-1249
bnguyen-bcgsc Sep 11, 2024
f069071
- Code lint
bnguyen-bcgsc Sep 11, 2024
980bd7b
Merge branch 'develop' into bugfix/KBDEV-1249-cant-add-variant-withou…
bnguyen-bcgsc Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/components/VariantForm/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ const VariantForm = ({

/* KBDEV-1216 Adding refAA to break1Start property when new variant has ProteinPosition coordinate system.
Property has the same value as refSeq and should be hidden from users to avoid confusion. */
if (payload?.break1Start['@class'] === 'ProteinPosition') {
if (payload?.break1Start && payload?.break1Start['@class'] === 'ProteinPosition') {
const refAA = payload.refSeq ? payload.refSeq : '';
payload.break1Start = { ...payload.break1Start, refAA };
}
Expand All @@ -167,10 +167,13 @@ const VariantForm = ({
: 'edited';

try {
const result = await formVariant === FORM_VARIANT.NEW
? api.post(routeName, payload)
: api.patch(`${routeName}/${content['@rid'].replace(/^#/, '')}`, payload);
let result;

if (formVariant === FORM_VARIANT.NEW) {
result = await api.post(routeName, payload);
} else {
result = await api.patch(`${routeName}/${content['@rid'].replace(/^#/, '')}`, payload);
}
snackbar.enqueueSnackbar(`Sucessfully ${actionType} the record ${result['@rid']}`, { variant: 'success' });
onSubmit(result);
} catch (err) {
Expand Down
Loading