-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update depenedencies and linting #102
Conversation
Steve-Mcl
commented
Aug 26, 2024
- Updates to latest MSSQL 10.x stream
- I have avoided switching to 11.x stream in this PR as it bumps Node requirement up to v18 minimum!
- This is someting that will need to be discussed.
- Remove some eslint overrides to be closer to eslint:recomended
- fix up resulting ESLINT errors
…??` operator in tedious!
@bestlong Thank you for fixing the CI runner - Tests are now passing. This PR updates linting on files closer to eslint standard Note I also added Node v20 into the matrix. PS: There are no functional changes to this code (it is all purely dependencies, linting and CI stuff) At some later time we should discuss how best to move to the MSSQL 11.x stream. |
NOTE: Once merged, I will be doing some more PRs (wanted to get code up to good standard first) So please do not do a release just yet - I will make a release PR at a later time. |
Hi @Steve-Mcl No problem, the part that I think must be dealt with has been completed, and it’s up to you to do the rest. |
@bestlong ok, thanks. If you could review and approve when you get time that would be great. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.