Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update depenedencies and linting #102

Merged
merged 12 commits into from
Aug 31, 2024
Merged

Update depenedencies and linting #102

merged 12 commits into from
Aug 31, 2024

Conversation

Steve-Mcl
Copy link
Collaborator

  • Updates to latest MSSQL 10.x stream
    • I have avoided switching to 11.x stream in this PR as it bumps Node requirement up to v18 minimum!
    • This is someting that will need to be discussed.
  • Remove some eslint overrides to be closer to eslint:recomended
    • fix up resulting ESLINT errors

@Steve-Mcl
Copy link
Collaborator Author

Steve-Mcl commented Aug 28, 2024

@bestlong Thank you for fixing the CI runner - Tests are now passing.

This PR updates linting on files closer to eslint standard
Also, it updates the CI to run lint as part of the test.

Note I also added Node v20 into the matrix.
All this gets rid of a few npm audit high priorities.

PS: There are no functional changes to this code (it is all purely dependencies, linting and CI stuff)


At some later time we should discuss how best to move to the MSSQL 11.x stream.
That will require Node v18 as minimum but that will break many legacy Node-RED installations (like where Node-RED is built into a hardware device with older, non maintained Firmware).
I realise this is not "our" problem but we should be mindful and not break things for folk who have no choice (if we can avoid it).

@Steve-Mcl Steve-Mcl requested a review from bestlong August 28, 2024 07:59
@Steve-Mcl
Copy link
Collaborator Author

NOTE: Once merged, I will be doing some more PRs (wanted to get code up to good standard first)

So please do not do a release just yet - I will make a release PR at a later time.

@bestlong
Copy link
Owner

Hi @Steve-Mcl

No problem, the part that I think must be dealt with has been completed, and it’s up to you to do the rest.

@Steve-Mcl
Copy link
Collaborator Author

@bestlong ok, thanks.

If you could review and approve when you get time that would be great.

Copy link
Owner

@bestlong bestlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Steve-Mcl Steve-Mcl changed the base branch from master to next August 31, 2024 07:26
@Steve-Mcl Steve-Mcl merged commit 75687c0 into next Aug 31, 2024
6 checks passed
@Steve-Mcl Steve-Mcl deleted the deps-and-linting branch August 31, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants