Add no_std support to bevy_state
#17028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bushrat011899
added
C-Feature
alice-i-cecile
approved these changes
Dec 29, 2024
alice-i-cecile
added
S-Needs-Review
bushrat011899
added
S-Ready-For-Final-Review
|
@bushrat011899 ping me to merge this once merge conflicts are resolved please :) |
|
@alice-i-cecile Conflicts resolved! It's a shame the git algorithm can't handle the way I add tests to that |
BenjaminBrienen
approved these changes
Dec 29, 2024
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Jan 6, 2025
# Objective - Contributes to bevyengine#15460 ## Solution - Added the following features: - `std` (default) - `portable-atomic` - `critical-section` ## Testing - CI ## Notes - `portable-atomic`, and `critical-section` are shortcuts to enable the relevant features in dependencies, making the usage of this crate on atomically challenged platforms possible and simpler. - This PR is blocked until bevyengine#17027 is merged (as it depends on fixes for the `once!` macro). Once merged, the change-count for this PR should reduce.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
no_stdBevy #15460Solution
std(default)portable-atomiccritical-sectionTesting
Notes
portable-atomic, andcritical-sectionare shortcuts to enable the relevant features in dependencies, making the usage of this crate on atomically challenged platforms possible and simpler.portable-atomicsupport tobevy_utilsforonce!#17027 is merged (as it depends on fixes for theonce!macro). Once merged, the change-count for this PR should reduce.