Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed PointerAction::Pressed to PointerAction::Button. #17424

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Renamed PointerAction::Pressed to PointerAction::Button. #17424

wants to merge 1 commit into from
+9 −9

Conversation

AlephCubed
Copy link
Contributor

Fixes #17397.

Migration Guide

  • PointerAction::Pressed has been renamed to PointerAction::Button.

@alice-i-cecile alice-i-cecile requested review from aevyrie and NthTensor and removed request for aevyrie January 19, 2025 06:14
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy C-Usability A targeted quality-of-life change that makes Bevy easier to use M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide X-Contentious There are nontrivial implications that should be thought through S-Needs-Review Needs reviewer attention (from anyone!) to move forward A-Picking Pointing at and selecting objects of all sorts labels Jan 19, 2025
alice-i-cecile
alice-i-cecile approved these changes Jan 19, 2025
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is much clearer, but I did make the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@NthTensor NthTensor Awaiting requested review from NthTensor

@aevyrie aevyrie Awaiting requested review from aevyrie

Assignees
No one assigned
Labels
A-Picking Pointing at and selecting objects of all sorts C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Needs-Review Needs reviewer attention (from anyone!) to move forward X-Contentious There are nontrivial implications that should be thought through
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename PointerAction::Pressed to PointerAction::Button
2 participants
@AlephCubed @alice-i-cecile