Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRAFT: no_std support for bevy and bevy_internal #17715

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

DRAFT: no_std support for bevy and bevy_internal #17715

wants to merge 1 commit into from
+452 −321

Conversation

bushrat011899
Copy link
Contributor

Objective

Solution

  • Threaded in new features as required
  • Made certain crates optional but default enabled
  • Changed compile-check-no-std to just check bevy itself

Testing

  • CI

Showcase

TODO

Migration Guide

TODO

@bushrat011899 bushrat011899 added C-Feature A new feature, making something new possible A-Cross-Cutting Impacts the entire engine X-Uncontroversial This work is generally agreed upon D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged O-Embedded Weird hardware and no_std platforms labels Feb 7, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

You added a new feature but didn't add a description for it. Please update the root Cargo.toml file.

TimJentzsch
TimJentzsch reviewed Feb 7, 2025
View reviewed changes
crates/bevy_internal/Cargo.toml
# Enable input focus subsystem
bevy_input_focus = ["dep:bevy_input_focus"]

# Enable logging integration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: there is a bit of an inconsistency in this file regarding the level of # and e.g. "enable" vs "enables"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimJentzsch TimJentzsch TimJentzsch left review comments

Assignees
No one assigned
Labels
A-Cross-Cutting Impacts the entire engine C-Feature A new feature, making something new possible D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes O-Embedded Weird hardware and no_std platforms S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking Issue: MVP no_std Bevy
2 participants
@bushrat011899 @TimJentzsch