Skip to content

Projection Improvements #18458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Projection Improvements #18458

wants to merge 3 commits into from
+48 −38

Conversation

aevyrie
Copy link
Member

@aevyrie aevyrie commented Mar 21, 2025

Objective

  • Remove a component impl footgun
  • Make projection code slightly nicer, and remove the need to import the projection trait when using the methods on Projection.

Solution

  • Do the things.

@aevyrie aevyrie added the C-Bug An unexpected or incorrect behavior label Mar 21, 2025
alice-i-cecile
alice-i-cecile reviewed Mar 21, 2025
View reviewed changes
crates/bevy_render/src/camera/projection.rs
@@ -201,6 +201,36 @@ impl CustomProjection {
}
}

// TODO: remove when trait upcasting is stabilized.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trait upcasting is merged into Rust, but not quite released. See rust-lang/rust#65991. Does it make sense to wait until April 3rd? https://releases.rs/docs/1.86.0/

@BenjaminBrienen BenjaminBrienen added A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward and removed C-Bug An unexpected or incorrect behavior labels Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile left review comments

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
Rendering
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aevyrie @alice-i-cecile @BenjaminBrienen