-
-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lint): implement noPrivateImports
#5388
Open
arendjr
wants to merge
10
commits into
biomejs:main
Choose a base branch
from
arendjr:no-private-imports
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,579
−675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f6a62e5
to
bf252a7
Compare
CodSpeed Performance ReportMerging #5388 will not alter performanceComparing Summary
|
ematipico
approved these changes
Mar 20, 2025
bc71c45
to
a1cd8fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-CLI
Area: CLI
A-Core
Area: core
A-Diagnostic
Area: diagnostocis
A-Linter
Area: linter
A-Project
Area: project
L-JavaScript
Language: JavaScript and super languages
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This implements the new rule
noPrivateImports
based on the previousnoPackagePrivateImports
(calleduseImportRestrictions
in 1.x).I've moved the rule to the
correctness
group, since it seems that repositories that would like to enforce such visibility rules would consider code that imports restricted symbols to be incorrect.I've made the rule part of the recommended set as well. This was made possible by changing the default visibility to public, meaning that the rule should only report on symbols with explicit visibility restrictions. For symbols with explicit restrictions, it seems sensible that we show diagnostics by default.
Furthermore, by enabling the rule by default, it gives us an opportunity to see the impact of the rule's performance in the real world. If users complain about the rule's behaviour or its performance, we can still remove it from the recommended set before 2.0 is final.
Thanks to @siketyan for helping with the implementation.
Test Plan
Tests added.