Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customising parameters related to disk cleanup #623

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

lox
Copy link
Contributor

@lox lox commented Aug 26, 2019

Allows the min disk threshold before docker cleanup as a parameter. Can be a unit or a percentage.

Closes #465.

@lox lox requested a review from plasticine August 26, 2019 07:49
Copy link

@plasticine plasticine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit to me, though I’ve not run the bash. Just a few queries and ponders from me but no show stoppers

packer/linux/conf/bin/bk-check-disk-space.sh Outdated Show resolved Hide resolved
packer/linux/conf/bin/bk-check-disk-space.sh Show resolved Hide resolved
packer/linux/conf/buildkite-agent/hooks/environment Outdated Show resolved Hide resolved
packer/linux/conf/buildkite-agent/hooks/environment Outdated Show resolved Hide resolved
@lox lox force-pushed the allow-min-disk-before-clean-to-be-customized branch from 28198ab to dfa2eb3 Compare October 6, 2019 23:08
@@ -375,6 +375,16 @@ Parameters:
- "false"
Default: "false"

MinimumDiskAvailableBeforeCleanup:
Type: String
Description: Either a percentage (%) or absolute unit (B, MB, GB) of disk below which disk cleanup is run
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What an absolute unit.

@keithduncan keithduncan added the agent health Relating to whether the agent is or should pull additional work label Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent health Relating to whether the agent is or should pull additional work custom-configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a way of customizing DOCKER_PRUNE_UNTIL, DISK_MIN_AVAILABLE, and DISK_MIN_INODES for the cron job
4 participants