generated from caikit/caikit-template
-
Notifications
You must be signed in to change notification settings - Fork 51
Add pt hf trainer #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gkumbhat
wants to merge
141
commits into
caikit:main
Choose a base branch
from
gkumbhat:add_pt_hf_trainer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add pt hf trainer #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9cdbace
to
3bfd53c
Compare
Thoughts on TODOs on the PR:
|
88020a7
to
4106ba7
Compare
Some preliminary tests to be done before merging
Notes
|
Notes from testingTest parameters
HF Trainer branchTime:
Main branch, No HF Trainer branch
HF Trainer branch
Main branch, No HF Trainer branch
HF Trainer branch
Multi-gpu testing (2 A100-80G)HF Trainer branch
|
this avoids printing a deprecation warning Signed-off-by: Daniele Trifirò <[email protected]> Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: gkumbhat <[email protected]>
…tion Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: Daniele Trifirò <[email protected]> Signed-off-by: gkumbhat <[email protected]>
…text_func "OTHER" is an invalid value for caikit.interfaces.nlp.data_model.text_generation.FinishReason, resulting in failed serialization of responses when querying the text generation endpoint. For `generate_text_func`, it is reasonable to assume that if the finish reason is not `EOS_TOKEN` or `STOP_SEQUENCE`, it must be `MAX_TOKENS`. Signed-off-by: Daniele Trifirò <[email protected]> Signed-off-by: gkumbhat <[email protected]>
… configuration Signed-off-by: Daniele Trifirò <[email protected]> Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: gkumbhat <[email protected]>
fixes caikit#245 Signed-off-by: Daniele Trifirò <[email protected]> Signed-off-by: gkumbhat <[email protected]>
… defaults Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: Daniele Trifirò <[email protected]> Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: Evaline Ju <[email protected]> Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: Evaline Ju <[email protected]>
Signed-off-by: Evaline Ju <[email protected]>
Signed-off-by: Daniele Trifirò <[email protected]> Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: Daniele Trifirò <[email protected]> Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: Daniele Trifirò <[email protected]> Signed-off-by: gkumbhat <[email protected]>
- add install subsection - add model serving subsection - cleanup docker section - add configuration subsection Signed-off-by: Daniele Trifirò <[email protected]> Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: Daniele Trifirò <[email protected]> Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: gkumbhat <[email protected]>
ed63133
to
45e6c18
Compare
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #175
Changes
random_seed
to prompt tuning training APINotes
dataset_type.from_generator
converted doesn't accept empty dataset and raises error. For this reason, I had to modifytrain_stream
in test and make them not emptyEvaluation
Prompt Tuning:
Fine tuning
TODO
infer_steps
function, since its currently not doing it the same waytrainer
would do, i.e not considering gradient checkpointing 🤔