Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate daily workflows into one workflow and add email notifs #1081

Merged
merged 14 commits into from
Sep 16, 2024

Conversation

pauladkisson
Copy link
Member

@pauladkisson pauladkisson commented Sep 13, 2024

This PR consolidates the daily workflows into dailies.yml and adds an email notif for each to make it easier to keep track of them all.

See https://github.com/catalystneuro/neuroconv/actions/runs/10889811236

Copy link
Collaborator

@h-mayorquin h-mayorquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM and it would make your work easier, right?

The only thing I would keep out is the s3 thing.

@pauladkisson
Copy link
Member Author

This LGTM and it would make your work easier, right?

Yes, definitely.

@pauladkisson
Copy link
Member Author

Looks like the daily docker tests have been failing for a while now: https://github.com/catalystneuro/neuroconv/actions/runs/10855171853/job/30127190657

Want to fix before merging this.

@h-mayorquin
Copy link
Collaborator

Ok. Looks like a credentials issue.

@pauladkisson
Copy link
Member Author

@pauladkisson
Copy link
Member Author

build-and-upload-docker-image-dev still failing tho: https://github.com/catalystneuro/neuroconv/actions/runs/10855171853/job/30127196383

@pauladkisson pauladkisson changed the title Consolidate daily workflow into one workflow and add email notifs Consolidate daily workflows into one workflow and add email notifs Sep 16, 2024
@pauladkisson pauladkisson enabled auto-merge (squash) September 16, 2024 20:05
@pauladkisson pauladkisson merged commit f950792 into main Sep 16, 2024
35 checks passed
@pauladkisson pauladkisson deleted the dailies branch September 16, 2024 22:09
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.43%. Comparing base (ad9f25d) to head (6583b3e).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1081   +/-   ##
=======================================
  Coverage   90.43%   90.43%           
=======================================
  Files         129      129           
  Lines        8052     8053    +1     
=======================================
+ Hits         7282     7283    +1     
  Misses        770      770           
Flag Coverage Δ
unittests 90.43% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants