-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate daily workflows into one workflow and add email notifs #1081
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM and it would make your work easier, right?
The only thing I would keep out is the s3 thing.
Yes, definitely. |
Looks like the daily docker tests have been failing for a while now: https://github.com/catalystneuro/neuroconv/actions/runs/10855171853/job/30127190657 Want to fix before merging this. |
Ok. Looks like a credentials issue. |
Ok, daily docker tests is passing now! https://github.com/catalystneuro/neuroconv/actions/runs/10858022361/job/30135424576 |
build-and-upload-docker-image-dev still failing tho: https://github.com/catalystneuro/neuroconv/actions/runs/10855171853/job/30127196383 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1081 +/- ##
=======================================
Coverage 90.43% 90.43%
=======================================
Files 129 129
Lines 8052 8053 +1
=======================================
+ Hits 7282 7283 +1
Misses 770 770
Flags with carried forward coverage won't be shown. Click here to find out more. |
This PR consolidates the daily workflows into dailies.yml and adds an email notif for each to make it easier to keep track of them all.
See https://github.com/catalystneuro/neuroconv/actions/runs/10889811236