Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a fast CI option for draft status #1082

Merged
merged 18 commits into from
Sep 17, 2024
Merged

Provide a fast CI option for draft status #1082

merged 18 commits into from
Sep 17, 2024

Conversation

h-mayorquin
Copy link
Collaborator

@h-mayorquin h-mayorquin commented Sep 13, 2024

This goes further than #1078.

The idea is the following. A two-tier CI depending on PR status (draft vs ready for review)

When the PR is on draft we only test on a minimal version of Python so simple errors can surface quickly.

Once the PR is ready for a review then we run the full python matrix to ensure that no error escapes the CI.

@pauladkisson thoughts?
I actually thought about going further and not run dev or live tests on draft but I first wanted to illustrate the idea.

https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/evaluate-expressions-in-workflows-and-actions#example

@h-mayorquin h-mayorquin added the CI label Sep 13, 2024
@h-mayorquin h-mayorquin self-assigned this Sep 13, 2024
Copy link
Member

@pauladkisson pauladkisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea overall, just added a few suggestions.

.github/workflows/deploy-tests.yml Outdated Show resolved Hide resolved
.github/workflows/deploy-tests.yml Outdated Show resolved Hide resolved
.github/workflows/testing.yml Outdated Show resolved Hide resolved
.github/workflows/testing.yml Outdated Show resolved Hide resolved
.github/workflows/deploy-tests.yml Show resolved Hide resolved
Copy link
Member

@pauladkisson pauladkisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@h-mayorquin h-mayorquin marked this pull request as ready for review September 16, 2024 20:12
@h-mayorquin h-mayorquin enabled auto-merge (squash) September 16, 2024 20:12
@h-mayorquin h-mayorquin marked this pull request as draft September 17, 2024 20:14
auto-merge was automatically disabled September 17, 2024 20:14

Pull request was converted to draft

@h-mayorquin h-mayorquin marked this pull request as ready for review September 17, 2024 21:03
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.44%. Comparing base (36464df) to head (33e735b).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1082   +/-   ##
=======================================
  Coverage   90.44%   90.44%           
=======================================
  Files         129      129           
  Lines        8055     8051    -4     
=======================================
- Hits         7285     7282    -3     
+ Misses        770      769    -1     
Flag Coverage Δ
unittests 90.44% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@h-mayorquin h-mayorquin merged commit 88a4c2f into main Sep 17, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants