-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a fast CI option for draft status #1082
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this idea overall, just added a few suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Pull request was converted to draft
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1082 +/- ##
=======================================
Coverage 90.44% 90.44%
=======================================
Files 129 129
Lines 8055 8051 -4
=======================================
- Hits 7285 7282 -3
+ Misses 770 769 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
This goes further than #1078.
The idea is the following. A two-tier CI depending on PR status (draft vs ready for review)
When the PR is on draft we only test on a minimal version of Python so simple errors can surface quickly.
Once the PR is ready for a review then we run the full python matrix to ensure that no error escapes the CI.
@pauladkisson thoughts?
I actually thought about going further and not run dev or live tests on draft but I first wanted to illustrate the idea.
https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/evaluate-expressions-in-workflows-and-actions#example