Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Draft] Ecephys integration of backend configuration #578

Closed
wants to merge 23 commits into from
Closed

[Draft] Ecephys integration of backend configuration #578

wants to merge 23 commits into from

Conversation

CodyCBakerPhD
Copy link
Member

Opening this because as I work on it I realize, doing this straight up as in the reference PR has the effect that this is a hard, immediate deprecation that breaks backcompatability

So this PR would specifically be a major version bump on the package; and the only way I can think to soften it is maybe keep the keyword arguments around for a while but throw DeprecationWarnings that they no longer do anything, and instructions on the new approach to setting the compression+iteration options

What do you think @h-mayorquin?

@CodyCBakerPhD CodyCBakerPhD self-assigned this Sep 25, 2023
@CodyCBakerPhD CodyCBakerPhD changed the title [Backend Configuration IVa] Integrate backend configuration to base interfaces and converter plus ecephys [Backend Configuration IVa] Ecephys tntegration of backend configuration Sep 30, 2023
@CodyCBakerPhD CodyCBakerPhD changed the title [Backend Configuration IVa] Ecephys tntegration of backend configuration [Backend Configuration IVa] Ecephys integration of backend configuration Sep 30, 2023
CodyCBakerPhD
CodyCBakerPhD commented Sep 30, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@h-mayorquin
Copy link
Collaborator

Now that #571 is completed @alejoe91 mentioned that he would like to help to test this. Let's hope he has some time on his hands : )

Base automatically changed from new_backend_add_configure_backend to main December 7, 2023 18:10
@alejoe91 alejoe91 mentioned this pull request Jan 2, 2024
Merged
@CodyCBakerPhD CodyCBakerPhD changed the base branch from main to set_data_io_debug January 2, 2024 19:12
Base automatically changed from set_data_io_debug to main January 4, 2024 18:05
@h-mayorquin h-mayorquin mentioned this pull request Mar 13, 2024
Closed
2 tasks
@CodyCBakerPhD CodyCBakerPhD changed the title [Backend Configuration IVa] Ecephys integration of backend configuration [Draft] Ecephys integration of backend configuration Apr 2, 2024
@CodyCBakerPhD
Copy link
Member Author

replaced by many others

@CodyCBakerPhD CodyCBakerPhD deleted the integrate_with_interfaces_and_converter branch April 9, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-mayorquin h-mayorquin Awaiting requested review from h-mayorquin

Assignees

@CodyCBakerPhD CodyCBakerPhD

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CodyCBakerPhD @h-mayorquin