Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Base extractor #367

Open
wants to merge 5 commits into
base: segmentation
Choose a base branch
from
Open

Add Base extractor #367

wants to merge 5 commits into from

Conversation

pauladkisson
Copy link
Member

@pauladkisson pauladkisson commented Sep 30, 2024

Awaiting #366 then will change base to 0.6.0dev.

This PR is the third of a series that implement breaking changes to fully standardize the roiextractors api and update/streamline the testing suite. Some of the main goals include

  • removing channels argument to enforce 1 channel/extractor
  • Switching to modularized mixins for testing and supporting pytest fixtures/parameterization
  • Standard input validation, numpy indexing for 'get' methods, etc.

This PR adds a BaseExtractor class and corresponding BaseExtractorMixin testing mixin to contain commonalities between ImagingExtractor and SegmenationExtractor (mostly methods concerned with _times).

@pauladkisson pauladkisson changed the title Base extractor Add Base extractor Sep 30, 2024
@pauladkisson pauladkisson mentioned this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant