Merge pull request #2029 from hzeller/20231019-multi-parent

SymbolTable: Gracefully handle current CHECK-fail
chipsalliance · Oct 21, 2023 · 66c8c26 · 66c8c26
2 parents 520ca4b + 3681b01
commit 66c8c26
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/verilog/analysis/symbol_table.cc b/verilog/analysis/symbol_table.cc
@@ -2017,7 +2017,12 @@ static void ResolveReferenceComponentNode(
   switch (component.ref_type) {
     case ReferenceType::kUnqualified: {
       // root node: lookup this symbol from its context upward
-      CHECK(node->Parent() == nullptr);
+      if (node->Parent() != nullptr) {
+        // TODO(hzeller): Is this a situation that should never happen thus
+        // be dealt with further up-stream ? (changed from a CHECK()).
+        LOG(WARNING) << *node << ": Parent exists " << *node->Parent() << "\n";
+        return;
+      }
       ResolveUnqualifiedName(&component, context, diagnostics);
       break;
     }