Pin bazel version to version 6 in MacOS #2045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2045 +/- ##
=======================================
Coverage 92.84% 92.84%
=======================================
Files 357 357
Lines 26396 26396
=======================================
Hits 24507 24507
Misses 1889 1889 ☔ View full report in Codecov by Sentry. |
By default, it comes with bazel 7, but that won't work with our version of protobuf. We can't update protobuf, as that doesn't work with bazel 4, which we currently have as minimum requirement. Disable Kythe Verification as it currently fails with some bazel version issues.
fangism
approved these changes
Dec 13, 2023
|
End of support for bazel 4 is end of January next year: https://bazel.build/release#support-matrix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, it comes with bazel 7, but that won't work with our version of protobuf.
We can't update protobuf, as that doesn't work with bazel 4, which we currently have as minimum requirement.