Don't initialize empty string_views. Find places that were not prepared. #2310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A string_view initialized with an empty string "" is different from a string_view that is empty initialized (it holds a nullptr). Make sure that all places that deal with string_views (from a testable perspective) also accept empty() with null string views.
hzeller
force-pushed
the
feature-20241223-empty-stringview
branch
from
fed1508 to
2a441da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A string_view initialized with an empty string "" is different from a string_view that is empty initialized (it holds a nullptr). Make sure that all places that deal with string_views (from a testable perspective) also accept empty() with null string views.