Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use std::string_view instead of absl::string_view. #2326

Merged

Conversation

hzeller
Copy link
Collaborator

@hzeller hzeller commented Jan 14, 2025

Now that we're compatible with all systems after
PR #2324, can switch to use std::string_view now.

@hzeller hzeller requested a review from fangism January 14, 2025 01:58
Now that we're compatible with all systems after
PR chipsalliance#2324, can switch to use std::string_view now.
@hzeller hzeller force-pushed the feature-20250113-use-std-stringview branch from 65777a7 to b7ff052 Compare January 14, 2025 04:45
Copy link
Collaborator

@fangism fangism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At long last, well done.

@hzeller hzeller merged commit f1f3f46 into chipsalliance:master Jan 15, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants