Better use of tags as map #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
X-Guardian
suggested changes
May 21, 2018
| envname = "${var.envname}" | ||
| envtype = "${var.envtype}" | ||
| } | ||
| tags = "${merge(var.tags, map("Name", format("%s", var.identifier_prefix)))}" |
There was a problem hiding this comment.
You are forcing the use of a Name tag assigned to the identifier_prefix, as well as any tags in the map. Can we not have this?
| variable "identifier_prefix" { | ||
| type = "string" | ||
| default = "" |
There was a problem hiding this comment.
Can we leave the default for the identifier_prefix?
| } | ||
|
|
||
| // Create single DB instance | ||
| resource "aws_rds_cluster_instance" "cluster_instance_0" { | ||
| identifier = "${var.identifier_prefix != "" ? format("%s-node-0", var.identifier_prefix) : format("%s-aurora-node-0", var.envname)}" | ||
| identifier = "${format("%s-node-0", var.identifier_prefix)}" |
There was a problem hiding this comment.
Allow the identifier_prefix to be empty
| envname = "${var.envname}" | ||
| envtype = "${var.envtype}" | ||
| } | ||
| tags = "${merge(var.tags, map("Name", format("%s", var.identifier_prefix)))}" |
| @@ -201,7 +201,7 @@ resource "aws_rds_cluster_instance" "cluster_instance_n" { | |||
| count = "${var.replica_scale_enabled ? var.replica_scale_min : var.replica_count}" | |||
| engine = "${var.engine}" | |||
| engine_version = "${var.engine-version}" | |||
| identifier = "${var.identifier_prefix != "" ? format("%s-node-%d", var.identifier_prefix, count.index + 1) : format("%s-aurora-node-%d", var.envname, count.index + 1)}" | |||
| identifier = "${format("%s-node-%d", var.identifier_prefix, count.index + 1)}" | |||
| envname = "${var.envname}" | ||
| envtype = "${var.envtype}" | ||
| } | ||
| tags = "${merge(var.tags, map("Name", format("%s", var.identifier_prefix)))}" |
| } | ||
|
|
||
| // Create DB Cluster | ||
| resource "aws_rds_cluster" "default" { | ||
| cluster_identifier = "${var.identifier_prefix != "" ? format("%s-cluster", var.identifier_prefix) : format("%s-aurora-cluster", var.envname)}" | ||
| cluster_identifier = "${format("%s-cluster", var.identifier_prefix)}" |
| @@ -266,7 +263,7 @@ data "aws_iam_policy_document" "monitoring-rds-assume-role-policy" { | |||
|
|
|||
| resource "aws_iam_role" "rds-enhanced-monitoring" { | |||
| count = "${var.monitoring_interval > 0 ? 1 : 0}" | |||
| name = "rds-enhanced-monitoring-${var.envname}" | |||
| name = "rds-enhanced-monitoring-${var.identifier_prefix}" | |||
There was a problem hiding this comment.
Suggest the iam_role name is parameterised
|
My thoughts on this:
|
|
Any movement on this? Seems like a pretty big gap and is putting us in the position of having to maintain our own fork just for this feature. |
|
I think we should go with #32 because it's backwards compatible and only deals with tags, not names. @zacharyabresch would #32 work for you? |
|
Definitely. I'm also looking for just tags to be functional. In the meantime, we're maintaining a private fork but we'd rather not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.