Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for tags #32

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

added support for tags #32

wants to merge 2 commits into from

Conversation

syalam
Copy link

@syalam syalam commented Mar 29, 2019

added support for custom tags

This module only tags envtype and envname on select resources. I made a backwards compatible change that allows developers to pass in their own set of standard tags which then gets merged with the default envtype and envname tags.

Tags are also applied to any RDS resource that supports them. This way all related resources are tagged appropriately.

main.tf Outdated Show resolved Hide resolved
@raymondbutcher
Copy link
Contributor

This change looks OK to me, except for 2 things:

  1. there are conflicts
  2. the README should be updated to include the new variable in the Inputs section

I prefer this one over #18 because #18 does additional things related to names and is not backwards compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants