Skip 'strange' Erlang GitHub release #12
Conversation
walro
requested review from
oskgu360,
gomoripeti,
LoisSotoLopez and
nordlundj
as code owners
There's a weird release at: https://github.com/erlang/otp/releases/tag/patch-base-26 - it makes us barf when trying to parse as a `Gem::Version`. Refactor a bit to support all strangeness in one place.
walro
force-pushed
the
skip-strange-release
branch
from
3924f3f to
735d907
Compare
| @@ -7,6 +7,14 @@ PLATFORMS = %w[amd64 arm64].freeze | |||
| # 24.2 supports OpenSSL 3 and modern gcc/autoconf versions | |||
| FIRST_SANE_VERSION = Gem::Version.new("24.2") | |||
|
|
|||
| def skip_release?(dist:, version:) | |||
| return true if version == "patch-base-26" | |||
There was a problem hiding this comment.
Should we have a comment about this? "unparseable version", "not a real release"
Or maybe it is obvious :)
There was a problem hiding this comment.
I was contemplating to add the URL to the release page, but figured it would be in the commit message. I can add something if you'd like
There was a problem hiding this comment.
Hehe, they have realized the mistake now and removed it from releases... Question what to do with this change then 🤔
There was a problem hiding this comment.
I'll close this, we can reopen and make adjustment the next time this happens (if it happens). Feels strange to add the indirection (method) for just one case and it will mess with git blame.
|
Erlang retracted the release, so it's no longer an issue. |
|
FTR comment from the Erlang/OTP team
|
|
Ah! Thanks, we should incorporate that then. Edit: #13 |
From #12 (comment) > Any tag that does not have a `OTP-` prefix you can ignore. We had a problem with a release called "patch-base-26", see #12 for more information.
From #12 (comment) > Any tag that does not have a `OTP-` prefix you can ignore. We had a problem with a release called "patch-base-26", see #12 for more information.
There's a weird release at: https://github.com/erlang/otp/releases/tag/patch-base-26 - it makes us barf when trying to parse as a
Gem::Version, see https://github.com/cloudamqp/erlang-packages/actions/runs/10880399934/job/30187120021#step:4:10.Refactor a bit to support all strangeness in one place.