Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip 'strange' Erlang GitHub release #12

Closed
wants to merge 1 commit into from
Closed

Skip 'strange' Erlang GitHub release #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions bin/missing-versions
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,14 @@ PLATFORMS = %w[amd64 arm64].freeze
# 24.2 supports OpenSSL 3 and modern gcc/autoconf versions
FIRST_SANE_VERSION = Gem::Version.new("24.2")

def skip_release?(dist:, version:)
return true if version == "patch-base-26"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a comment about this? "unparseable version", "not a real release"
Or maybe it is obvious :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was contemplating to add the URL to the release page, but figured it would be in the commit message. I can add something if you'd like

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hehe, they have realized the mistake now and removed it from releases... Question what to do with this change then 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll close this, we can reopen and make adjustment the next time this happens (if it happens). Feels strange to add the indirection (method) for just one case and it will mess with git blame.

# Debian Bookworm doesn't have gcc 9 which is required for erlang <24.2
return true if dist == "debian/bookworm" && Gem::Version.new(version) < FIRST_SANE_VERSION

false
end

packagecloud = Packagecloud.new
github = Github.new

Expand All @@ -17,8 +25,7 @@ github.releases do |r|
next if r["tag_name"].include? "-rc"
version = r["tag_name"].sub("OTP-", "")
DISTS.each do |dist|
# Debian Bookworm doesn't have gcc 9 which is required for erlang <24.2
next if dist == "debian/bookworm" && Gem::Version.new(version) < FIRST_SANE_VERSION
next if skip_release?(dist:, version:)
PLATFORMS.each do |platform|
filename = "esl-erlang_#{version}-1_#{platform}.deb"
next if packagecloud.exists? dist, filename
Expand Down