-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oauth2 support #861
base: main
Are you sure you want to change the base?
Oauth2 support #861
Conversation
Looking at how RabbitMQ works and with Carl's answer, I understood that you could configure a list of authentication/authorization services and the calls were made in sequence. I had written this
end with AuthenticationService which looks like what you did with the Handler
end |
On the config side, I also followed Carl's advice by adding an auth section to have the order of the auth services and their config
|
In my opinion, the current user store should be the default if no config. |
@JadeKharats thanks for your comments, seems like we have similar idéas then! |
ad938f1
to
ca4e8ff
Compare
WHAT is this pull request doing?
This is a WIP
ConnectionFactory uses a chain of responsibility with authentication handlers to work through different authentication backends.
The idéa is that
config
will state the authentication backends one wishes to use.ConnectionFactory
will then initialize authentication handlers for those backends.Those handlers will then chain the responsibility of authenticating and returning a user, or nil if no authentication method was successful
here is an example where we configure two authentication methods, basic auth and Oauth2
This PR aims to adress #857 and potentially also #246
HOW can this pull request be tested?
WIP