Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure go packages #37

Merged
merged 6 commits into from
Sep 5, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Create struct with values
... instead of assigning after instantiation.
aramprice committed Jul 26, 2024
commit ea7ca188e5f4c5b16529b094e4b01f7451a7d574
19 changes: 9 additions & 10 deletions package_stemcell/factory/packager_factory.go
Original file line number Diff line number Diff line change
@@ -40,19 +40,18 @@ func (f *PackagerFactory) Packager(sourceConfig config.SourceConfig, outputConfi
}, nil
case config.VMDK:
options :=
package_parameters.VmdkPackageParameters{}

vmdkPackager := &packagers.VmdkPackager{
package_parameters.VmdkPackageParameters{
VMDKFile: sourceConfig.Vmdk,
OSVersion: strings.ToUpper(outputConfig.Os),
Version: outputConfig.StemcellVersion,
OutputDir: outputConfig.OutputDir,
}

return &packagers.VmdkPackager{
Stop: make(chan struct{}),
BuildOptions: options,
Logger: logger,
}

vmdkPackager.BuildOptions.VMDKFile = sourceConfig.Vmdk
vmdkPackager.BuildOptions.OSVersion = strings.ToUpper(outputConfig.Os)
vmdkPackager.BuildOptions.Version = outputConfig.StemcellVersion
vmdkPackager.BuildOptions.OutputDir = outputConfig.OutputDir
return vmdkPackager, nil
}, nil
default:
return nil, errors.New("unable to determine packager")
}