drpcserver: add server interceptor support in drpc #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for server interceptors in drpc. Interceptors are taken as server options, while instantiating the server. All interceptors added via server options are chained into a single server interceptor. Unlike grpc, here there is no separation between unary and stream interceptors because the unerdlying logic of handling the rpc calls is the same i.e. `drpc.Handler`'s `handleRPC` implementation. In grpc, we have separate processing for unary rpc's and stream rpc's. This common processing for both stream and unary rpcs has helped condense the interceptor interfaces into a single interface that works for both use-cases, essentially simplifying the logic of initializing and wiring of interceptors. Fixes: #147622 Epic: CRDB-51168
shaikzakiriitm
force-pushed
the
server-interceptors
branch
from
b730053 to
2f6c30f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added server interceptor support in drpc. Created the interface for server
interceptor and wired it into the server logic to be executed before actual
handler is executed.
Unlike grpc, here there is no separation between unary and stream
interceptors because the unerdlying logic of handling the rpc calls
is the same i.e.
drpc.Handler'shandleRPCimplementation. In grpc,we have separate processing for unary rpc's and stream rpc's. This
common processing for both stream and unary rpcs has helped condense
the interceptor interfaces into a single interface that works for both
use-cases, essentially simplifying the logic of initializing and
wiring of interceptors.
Fixes: #147622
Epic: CRDB-51168