Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDF-20144: remove wdl tests and mark deprecated #856

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Conversation

dmivankov
Copy link
Contributor

@dmivankov dmivankov commented Oct 31, 2023

wdl didn't hit GA and has no active usage through Scala SDK
and so no active usage through spark-datasource either.

Let's start by removing tests and marking deprecated.
Removing tests has a benefit of getting closer to being able
to run repo tests in any project (wdl tests can only be run in
dedicated projects with wdl access anyway).

CDF-20144

@dmivankov dmivankov requested a review from a team as a code owner October 31, 2023 10:04
@dmivankov dmivankov self-assigned this Oct 31, 2023
wdl didn't hit GA and has no active usage through Scala SDK
and so no active usage through spark-datasource either.

Let's start by removing tests and marking deprecated.
Removing tests has a benefit of getting closer to being able
to run repo tests in any project (wdl tests can only be run in
dedicated projects with wdl access anyway).

[CDF-20144]
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #856 (b83dd73) into master (913920d) will decrease coverage by 3.63%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #856      +/-   ##
==========================================
- Coverage   78.77%   75.14%   -3.63%     
==========================================
  Files          48       48              
  Lines        3020     3022       +2     
  Branches      135      129       -6     
==========================================
- Hits         2379     2271     -108     
- Misses        641      751     +110     
Files Coverage Δ
...gnite/spark/v1/FlexibleDataModelBaseRelation.scala 64.93% <100.00%> (+0.30%) ⬆️
...n/scala/cognite/spark/v1/wdl/JsonObjectToRow.scala 0.00% <ø> (-8.83%) ⬇️
...rc/main/scala/cognite/spark/v1/wdl/RowToJson.scala 0.00% <ø> (-61.02%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Contributor

@mr-celo mr-celo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪦💀 (not yet.. but closer to the grave..)

@sighol

Copy link
Contributor

@sighol sighol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dmivankov dmivankov merged commit 671ffb1 into master Nov 6, 2023
1 of 2 checks passed
@dmivankov dmivankov deleted the CDF-20144 branch November 6, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants