ui: remove GPS status from the sidebar #33304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UI Screenshots
|
selfdrive/ui/qt/sidebar.cc
Outdated
| @@ -100,9 +100,17 @@ void Sidebar::updateState(const UIState &s) { | |||
| setProperty("tempStatus", QVariant::fromValue(tempStatus)); | |||
|
|
|||
| ItemStatus pandaStatus = {{tr("VEHICLE"), tr("ONLINE")}, good_color}; | |||
| bool gpsOK = true; | |||
There was a problem hiding this comment.
let's just remove gps from the sidebar
sshane
reviewed
Aug 14, 2024
fredyshox
changed the title
programanichiro
added a commit
to programanichiro/openpilot
that referenced
this pull request
Aug 18, 2024
GPS->GNSS , SEARCH->EXPLORE Merge commit 'c61d504516158d1e9926cf09625bbfc87aba9664' into master-cit0 # Conflicts: # selfdrive/controls/controlsd.py # selfdrive/ui/ui.cc
Edison-CBS
pushed a commit
to Edison-CBS/openpilot
that referenced
this pull request
Sep 15, 2024
* Remove usage of llk in ui * Remove GPS from sidebar * Remove it from test old-commit-hash: c61d504
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.