Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cabana: enhance freq calculation and add zero division protection #34121

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

deanlee
Copy link
Contributor

@deanlee deanlee commented Nov 27, 2024

  1. Improved Frequency Calculation: Subtracted 1 from the event count to match the intervals between events, enhancing accuracy.
  2. Zero Division Protection: Added safeguards to avoid division by zero when event duration is zero.

@github-actions github-actions bot added the tools label Nov 27, 2024
@maxime-desroches maxime-desroches merged commit 8e14e40 into commaai:master Nov 27, 2024
18 checks passed
@deanlee deanlee deleted the cabana_fix_freq_calc branch November 27, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants