Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI groundwork for report/map page #19

Closed
wants to merge 1 commit into from

Conversation

Arbyhisenaj
Copy link
Member

Description

  • Correct the components.json file by chaging the basecolour back to slate (wasn't before becuase I though i could use a tailwind extended colour "meepGray-500"
  • Added the UI for the map page using shadcn components mostly but also created custom components for the constituency items in the constituency data list
  • Tried to set the color of the 'first and second in 2019' circles to be dynamic by using the party name as a prop in the styling e.g className=bg-${first2019lowercase} which might equal 'bg-labour' which is an extended colour we set in the tailwind config - but sometimes this doesn't seem to work, sometimes it does
  • Added the rest of the fonts

Motivation and Context

How Can It Be Tested?

How Will This Be Deployed?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I've checked the spec (e.g. Figma file) and documented any divergences.
  • My code follows the code style of this project.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I've updated the documentation accordingly.
  • Replace unused checkboxes with bullet points.

@janbaykara janbaykara mentioned this pull request Mar 12, 2024
4 tasks
@conatus
Copy link
Member

conatus commented Mar 12, 2024

@Arbyhisenaj

Can you please fill out the remainder of the pull request template, especially the How Can It Be Tested? element. Thanks.

@janbaykara janbaykara mentioned this pull request Mar 14, 2024
4 tasks
@conatus
Copy link
Member

conatus commented Mar 18, 2024

@janbaykara

Feels like we can close this PR out and merge this code in with #25, as feels it is implicitly reviewed by you using it in anger to build out the map for real.

Open again if you disagree.

@conatus conatus closed this Mar 18, 2024
@ev-sc ev-sc deleted the UI-groundwork-for-report/map-page branch December 1, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants