Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Members map [MEEP-140] #25

Merged
merged 20 commits into from
Mar 18, 2024
Merged

Members map [MEEP-140] #25

merged 20 commits into from
Mar 18, 2024

Conversation

janbaykara
Copy link
Member

@janbaykara janbaykara commented Mar 14, 2024

An MVP for displaying imported member data on a map.

(This PR inherits code from @Arbyhisenaj's work in #19 and merges it into the #24 branch in order to build off the API advances there.)

Description

Features

  • Create, edit and delete map reports
  • Add data sources as layers to map reports
  • Manual data import button for data sources, which now geo-codes data for use in mapping
  • Some fixes for the data source creation workflow

Codebase

  • Adds NextJS route groups to manage different layout variants.
  • Adds authenticated GraphiQL route for easier debugging

How Can It Be Tested?

Click 'reports' in the header, then create a report and add a data source that has some postcode data. You should see the pins on the map.

You can also run python manage.py test hub.tests.test_sources to verify tests are running correctly.

Screenshots (if appropriate):

Screenshot 2024-03-17 at 23 13 44 Screenshot 2024-03-17 at 23 15 41

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • I've checked the spec (e.g. Figma file) and documented any divergences.
  • My code follows the code style of this project.

Copy link

linear bot commented Mar 14, 2024

Copy link

render bot commented Mar 14, 2024

@janbaykara janbaykara marked this pull request as ready for review March 17, 2024 22:40
@conatus
Copy link
Member

conatus commented Mar 18, 2024

Assuming that the real action here begins with 8207ede and going from here.

Copy link
Member

@conatus conatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is safe enough to try, from a code review level. Builds on other bits, which I have reviewed in detail.

Balancing reviewing a really large pull request with the fact that sometimes at this stage in work, pull requests are large. Can we try and keep them a little smaller from here on in, ha.

nextjs/src/services/apollo-client.ts Outdated Show resolved Hide resolved
This was referenced Mar 18, 2024
@janbaykara janbaykara merged commit cb60319 into main Mar 18, 2024
2 checks passed
@ev-sc ev-sc deleted the members-map branch December 1, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants