-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Members map [MEEP-140] #25
Conversation
Your Render PR Server URL is https://meep-intelligence-hub-frontend-pr-25.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cnpk9nf79t8c73dt9ktg. |
Assuming that the real action here begins with 8207ede and going from here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is safe enough to try, from a code review level. Builds on other bits, which I have reviewed in detail.
Balancing reviewing a really large pull request with the fact that sometimes at this stage in work, pull requests are large. Can we try and keep them a little smaller from here on in, ha.
An MVP for displaying imported member data on a map.
(This PR inherits code from @Arbyhisenaj's work in #19 and merges it into the #24 branch in order to build off the API advances there.)
Description
Features
Codebase
How Can It Be Tested?
Click 'reports' in the header, then create a report and add a data source that has some postcode data. You should see the pins on the map.
You can also run
python manage.py test hub.tests.test_sources
to verify tests are running correctly.Screenshots (if appropriate):
Types of changes
Checklist: