Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update java runtime to work with mac m3 / sequioa 15.3 #1872

Merged
merged 1 commit into from
Jan 15, 2025
Merged

update java runtime to work with mac m3 / sequioa 15.3 #1872

merged 1 commit into from
Jan 15, 2025

Conversation

tevko
Copy link
Collaborator

@tevko tevko commented Jan 15, 2025

No description provided.

@tevko
Copy link
Collaborator Author

tevko commented Jan 15, 2025

related discussion: corretto/corretto-21#85 (comment)

@ballPointPenguin
Copy link
Contributor

This seems ok.
I've been running these containers on an M3 Macbook with OS Sequoia without any issues.
Should the temurin version and the java runtime be synced? like both version 21?

@tevko
Copy link
Collaborator Author

tevko commented Jan 15, 2025

This seems ok. I've been running these containers on an M3 Macbook with OS Sequoia without any issues. Should the temurin version and the java runtime be synced? like both version 21?

It doesn't seem like they need to be synced, this is running locally on a fresh container after running docker system prune

ballPointPenguin
ballPointPenguin requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@ballPointPenguin ballPointPenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sync java version to (LTS) version 21

math/Dockerfile
@@ -1,4 +1,4 @@
FROM docker.io/clojure:tools-deps-bullseye
FROM docker.io/clojure:temurin-17-tools-deps
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
FROM docker.io/clojure:temurin-17-tools-deps
FROM docker.io/clojure:temurin-21-tools-deps

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately the issue reappears when theyre both 21

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tevko Can you explain why you want to indicate the wrong version that you are not using in math system properties?

Also I built and ran the images successfully on Mac M3 using v21 in both files. So your issue might be something else.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #1874

@tevko tevko merged commit a92e522 into edge Jan 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ballPointPenguin ballPointPenguin ballPointPenguin requested changes

@colinmegill colinmegill Awaiting requested review from colinmegill

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tevko @ballPointPenguin