Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update java runtime to work with mac m3 / sequioa 15.3 #1872

Merged
merged 1 commit into from
Jan 15, 2025
Merged

update java runtime to work with mac m3 / sequioa 15.3 #1872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion math/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM docker.io/clojure:tools-deps-bullseye
FROM docker.io/clojure:temurin-17-tools-deps

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
FROM docker.io/clojure:temurin-17-tools-deps
FROM docker.io/clojure:temurin-21-tools-deps

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately the issue reappears when theyre both 21

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tevko Can you explain why you want to indicate the wrong version that you are not using in math system properties?

Also I built and ran the images successfully on Mac M3 using v21 in both files. So your issue might be something else.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #1874

WORKDIR /app
COPY . .
Expand Down
2 changes: 1 addition & 1 deletion math/system.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
java.runtime.version=1.8
java.runtime.version=21
Loading