Use Files instead of FileItems
#904
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevorgerhardt
force-pushed
the
use-files-directly
branch
from
0467676
to
c7317e1
Compare
trevorgerhardt
force-pushed
the
use-files-directly
branch
2 times, most recently
from
d3e4a8f
to
7cd21db
Compare
We use Apache FileUpload to assist with handling incoming files. We also use a DiskItemFactory that persists each incoming file to disk immediately. This means that we could represent each incoming file as a java.io.File instead of a FileItem. java.io.File is a much more common way of handling a file and easier to work with.
trevorgerhardt
force-pushed
the
use-files-directly
branch
from
7cd21db
to
b0e72e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert
FileItems intojava.io.Files before processing. We use Apache's FileUpload library to assist with handling incoming files using aDiskFileItemFactorythat persists each incoming file to disk immediately. This means it is simple to convert each incoming file as ajava.io.Fileinstead of aFileItem.java.io.Fileis a much more common way of handling a file and will be easier to work with.